FIO-8420: file component no defaults causes error #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanbond
approved these changes
Jun 11, 2024
TanyaGashtold
requested changes
Jun 17, 2024
src/components/file/File.js
Outdated
| @@ -744,7 +744,7 @@ export default class FileComponent extends Field { | |||
| const fileWithSameNameUploading = this.filesToSync.filesToUpload | |||
| .some(fileToSync => fileToSync.file?.name === file.name); | |||
|
|
|||
| const fileWithSameNameUploaded = this.dataValue | |||
| const fileWithSameNameUploaded = this.dataValue && this.dataValue | |||
| .some(fileStatus => fileStatus.originalName === file.name); | |||
There was a problem hiding this comment.
I'd prefer to make this check even more secure by checking if this.dataValue is an array. Or you can just use lodash, like this:
_.some(this.dataValue, fileStatus => fileStatus.originalName === file.name);
Lodash does all the checking on the incoming value on its own and doesn't throw an error even if this.dataValue is undefine/string/number etc.
There was a problem hiding this comment.
Replaced check with lodash.some function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8420
Description
What changed?
Previously, formio.js would error on a file upload if the noDefaults option in Formio.createForm function was set to true. This PR replaces this behavior by validating that this.dataValue exists before calling the .some function on it.
Why have you chosen this solution?
Although there were many potential solutions my solution was best because it does not cause any new errors/bugs to appear in the code and allows the next couple of lines of code to work without modification.
Dependencies
N/A
How has this PR been tested?
I added automated tests and manually tested
Checklist: